Skip to content

Configuration property metadata includes incorrect class references#50375

Closed
Kimgyuilli wants to merge 1 commit into
spring-projects:mainfrom
Kimgyuilli:fix-stale-configuration-metadata-source-types
Closed

Configuration property metadata includes incorrect class references#50375
Kimgyuilli wants to merge 1 commit into
spring-projects:mainfrom
Kimgyuilli:fix-stale-configuration-metadata-source-types

Conversation

@Kimgyuilli
Copy link
Copy Markdown
Contributor

@Kimgyuilli Kimgyuilli commented May 8, 2026

This updates stale type and sourceType references in additional configuration metadata after package changes and type removals.

The updated metadata now points to existing classes, avoiding references to removed or relocated types.

Validation:

./gradlew :module:spring-boot-opentelemetry:checkAdditionalSpringConfigurationMetadata :module:spring-boot-mail:checkAdditionalSpringConfigurationMetadata :module:spring-boot-jdbc:checkAdditionalSpringConfigurationMetadata :module:spring-boot-actuator-autoconfigure:checkAdditionalSpringConfigurationMetadata :module:spring-boot-micrometer-metrics:checkAdditionalSpringConfigurationMetadata

Signed-off-by: Kimgyuilli <rlarbdlf222@naver.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 8, 2026
@philwebb philwebb added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels May 8, 2026
@philwebb philwebb added this to the 4.0.x milestone May 8, 2026
@philwebb philwebb changed the title Fix stale type references in additional configuration metadata Configuration property metadata includes incorrect class references May 8, 2026
@philwebb
Copy link
Copy Markdown
Member

philwebb commented May 8, 2026

Thanks. I think we might be able to drop the wavefront property entirely. We'll take care of that when we merge this.

@philwebb philwebb added the for: merge-with-amendments Needs some changes when we merge label May 8, 2026
@snicoll
Copy link
Copy Markdown
Member

snicoll commented May 29, 2026

I disagree that we should remove the wavefront properties. Those were marked as removed in 4.0 so the hint can't be removed in 4.0.x. Also, configuration properties hint don't have the same lifecycle as our general deprecation policy. Keeping this information longer is beneficial to tool (the properties migrator) and IDE support.

pull Bot pushed a commit to fuyl1988/spring-boot that referenced this pull request May 30, 2026
@snicoll snicoll closed this in f6f1d57 May 30, 2026
@snicoll snicoll removed the for: merge-with-amendments Needs some changes when we merge label May 30, 2026
@snicoll snicoll modified the milestones: 4.0.x, 4.0.7 May 30, 2026
@snicoll
Copy link
Copy Markdown
Member

snicoll commented May 30, 2026

Thanks for the PR.

SourceType on error-level properties should not be there in the first place. I've removed the few entries that had one (including the one that had staled value).

@snicoll snicoll self-assigned this May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants