SSL should not be enabled when a SSL bundle is overridden to an empty string#50624
Merged
snicoll merged 2 commits intoMay 30, 2026
Merged
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
changed the title
Update the Cassandra, Redis, and MongoDB SSL configuration so that an empty `bundle` property is treated as unset rather than enabling SSL. See spring-projectsgh-50624 Signed-off-by: Lee JiWon <dlwldnjs1009@gmail.com>
Update Mail SSL configuration as well. See spring-projectsgh-50624
snicoll
added
type: bug
snicoll
force-pushed
the
treat-empty-ssl-bundle-as-unset
branch
from
546f271 to
88a7a44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #50429, which treated an empty RabbitMQ SSL bundle as unset.
Ssl.isEnabled()in Cassandra, Redis, and MongoDB still derivedenablement from
this.bundle != null, so an emptybundlevalue enabledSSL instead of being treated as unset. They now use
StringUtils.hasText,matching RabbitMQ and the existing Couchbase behavior.
Testing:
CassandraPropertiesTests.sslIsNotEnabledWhenBundleIsEmptyRedisPropertiesTests.sslIsNotEnabledWhenBundleIsEmptyMongoPropertiesTests.sslIsNotEnabledWhenBundleIsEmpty