Automatic baggage propagation from gRPC metadata#369
Open
o-shevchenko wants to merge 2 commits intospring-projects:mainfrom
Open
Automatic baggage propagation from gRPC metadata#369o-shevchenko wants to merge 2 commits intospring-projects:mainfrom
o-shevchenko wants to merge 2 commits intospring-projects:mainfrom
Conversation
o-shevchenko
force-pushed
the
gh-368
branch
3 times, most recently
from
083b4dd to
a9479ba
Compare
Contributor
Author
Implements automatic propagation of OpenTelemetry baggage between gRPC services via metadata headers. Client side: GrpcHeaderClientInterceptor propagates baggage values as gRPC metadata headers in outbound calls based on management.tracing.baggage.remote-fields configuration. Server side: GrpcHeaderServerInterceptor extracts metadata headers into baggage for downstream propagation and adds them as span tags based on management.tracing.baggage.tag-fields configuration. Both interceptors properly manage BaggageInScope lifecycle with guaranteed cleanup on call completion or cancellation. Signed-off-by: Oleksandr Shevchenko <shevchenko.olexandr96@gmail.com>
Contributor
|
👋🏻 @o-shevchenko , Thank you for the contribution 🎉 ! Note 🚧 🚧 🚧 Because this change resides in the auto-configuration which we are in the process of moving to Spring Boot (see #234) we will review this but merging will be delayed until after the migration completes. Please pardon our mess while under construction 👷🏻 🏗️ . Thank you for your patience. |
onobc
added
status: post-spring-boot-migration
Contributor
Author
|
@onobc Do we have any release data for such a work with Spring Boot migration? |
Contributor
|
👋🏻 @o-shevchenko we are aiming to get a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements automatic propagation of OpenTelemetry baggage between gRPC services via metadata headers.
Integrate it with current Spring Boot actuator confs for HTTP headers
Client side: GrpcHeaderClientInterceptor propagates baggage values as gRPC metadata headers in outbound calls based on management.tracing.baggage.remote-fields configuration.
Server side: GrpcHeaderServerInterceptor extracts metadata headers into baggage for downstream propagation and adds them as span tags based on management.tracing.baggage.tag-fields configuration.
[resolves #368]