Fix health auto-configuration condition timing#381
Open
therepanic wants to merge 1 commit intospring-projects:mainfrom
Open
Fix health auto-configuration condition timing#381therepanic wants to merge 1 commit intospring-projects:mainfrom
therepanic wants to merge 1 commit intospring-projects:mainfrom
Conversation
Fixes a timing issue. Currently, the logic in GrpcServerHealthAutoConfiguration.OnHealthIndicatorPathsCondition is incorrect; it can never find the bean, since the condition itself is checked before the beans themselves are created. The tests passed because we were passing the bean itself, not the autoconfiguration with the bean. Closes: spring-projectsgh-380 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
therepanic
commented
Mar 3, 2026
Comment on lines
+133
to
+138
| static class OnHealthDefaultEnablementCondition extends SpringBootCondition implements ConfigurationCondition { | ||
|
|
||
| @Override | ||
| public ConfigurationCondition.ConfigurationPhase getConfigurationPhase() { | ||
| return ConfigurationCondition.ConfigurationPhase.REGISTER_BEAN; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Our main mistake was believing it worked the way the tests ran. I described in the commit why it didn't work and that, as far as I'm concerned, this approach works, unless I'm missing any other inputs.
dsyer
added
the
status: post-spring-boot-migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a timing issue. Currently, the logic in
GrpcServerHealthAutoConfiguration.OnHealthIndicatorPathsConditionis incorrect; it can never find the bean, since the condition itself is checked before the beans themselves are created. The tests passed because we were passing the bean itself, not the autoconfiguration with the bean.Closes: gh-380