Moves autoconfiguration and starters to Spring Boot#388
Open
onobc wants to merge 6 commits intospring-projects:mainfrom
Open
Moves autoconfiguration and starters to Spring Boot#388onobc wants to merge 6 commits intospring-projects:mainfrom
onobc wants to merge 6 commits intospring-projects:mainfrom
Conversation
See spring-projects#234 Signed-off-by: onobc <chris.bono@gmail.com>
Removes the configuration properties generation and updates the docs to reflect the move of the autoconfiguration to Spring Boot. See spring-projects#234 Signed-off-by: onobc <chris.bono@gmail.com>
Moves dependencies now managed by Spring Boot from `spring-grpc-dependencies` to `spring-grpc-build-dependencies`. See spring-projects#234 Signed-off-by: onobc <chris.bono@gmail.com>
Many of the samples are still failing and the tests have been marked
with `@Disabled("Need to migrate to Spring Boot 4.1.x")`.
See spring-projects#234
Signed-off-by: onobc <chris.bono@gmail.com>
onobc
force-pushed
the
GH-234-migrate-boot
branch
from
8d0ac31 to
a25e2e2
Compare
…docs. Signed-off-by: onobc <chris.bono@gmail.com>
- Grpc Java to `1.79.0` - Protobuf Java to `4.34.0` - Spring Framework to `7.0.6` - Spring Security to `7.1.0-M2` - Micrometer to `1.17.0-M3` - Netty to `4.2.10-Final` - Jackson to `2.21.1` - Junit to `6.0.3` - AssertJ to `3.27.7` Signed-off-by: onobc <chris.bono@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the auto-configuration and starter modules.
The
samplesmodule is also currently removed from the list of modules to allow the CI PR to pass.I have updated the samples as far as I can but there are still many failures when running the samples tests.
One that is causing many of the failues is when the app property for the client channel target is defined w/
local.grpc.server.portin it, e.g.:it fails w/
It is not being resolved.
The failing samples can be found by searching for
cc: @dsyer @philwebb
We should dig into these failures before releasing as I think there may be some issues w/ the new virtual targets etc..
See #234