Fix equals nullability annotations for jspecify compliance#18930
Merged
jzheaux merged 1 commit intospring-projects:mainfrom Mar 23, 2026
Merged
Fix equals nullability annotations for jspecify compliance#18930jzheaux merged 1 commit intospring-projects:mainfrom
jzheaux merged 1 commit intospring-projects:mainfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
therepanic
commented
Mar 18, 2026
...n/java/org/springframework/security/kerberos/authentication/KerberosServiceRequestToken.java
Outdated
Show resolved
Hide resolved
jzheaux
requested changes
Mar 21, 2026
Contributor
jzheaux
left a comment
jzheaux
left a comment
There was a problem hiding this comment.
Thanks, @therepanic, for the PR and the underlying research that went into it.
Does this also close #18927? If so, you may consider adding that Closes to your commit as well. Otherwise, will you please elaborate on that ticket what work is needed in addition to this PR?
.../java/org/springframework/security/access/method/DelegatingMethodSecurityMetadataSource.java
Outdated
Show resolved
Hide resolved
...n/java/org/springframework/security/kerberos/authentication/KerberosServiceRequestToken.java
Outdated
Show resolved
Hide resolved
jzheaux
added
in: core
jzheaux
added
the
status: waiting-for-feedback
therepanic
force-pushed
the
jspecify-nullable-on-equals
branch
3 times, most recently
from
1a9e130 to
901d7d9
Compare
Contributor
Author
spring-projects-issues
added
status: feedback-provided
jzheaux
approved these changes
Mar 23, 2026
In this commit, we added `@Nullable` to equals methods of classes that support `jspecify` for consistency with other Spring projects and to avoid bugs that caused other Spring projects to do this natively. Closes: spring-projectsgh-18929, spring-projectsgh-18927 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
jzheaux
force-pushed
the
jspecify-nullable-on-equals
branch
from
901d7d9 to
cf51b82
Compare
Contributor
|
Nice, @therepanic! Thanks for the updates. This will merge into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit, we added
@Nullableto equals methods of classes that supportjspecifyfor consistency with other Spring projects and to avoid bugs that caused other Spring projects to do this natively.Closes: gh-18929