Add hook for adding authentication filters#19320
Open
therepanic wants to merge 1 commit into
Open
Conversation
This change will allow us to directly add authentication filters without resorting to various hacks by directly overriding the protected `addAuthenticationFilter` method. Closes: spring-projectsgh-19319 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
therepanic
commented
Jun 11, 2026
Comment on lines
+306
to
313
|
|
||
| /** | ||
| * Adds the authentication filter | ||
| * @param http the {@link HttpSecurityBuilder} | ||
| * @param filter the authentication filter | ||
| */ | ||
| protected void addAuthenticationFilter(B http, F filter) { | ||
| http.addFilter(filter); |
Contributor
Author
There was a problem hiding this comment.
Although this name makes perfect sense, we could consider another option if anyone has better ideas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will allow us to directly add authentication filters without resorting to various hacks by directly overriding the protected
addAuthenticationFiltermethod.Closes: gh-19319