#19329 fix ipv4 vs ipv6 in ip inet address matcher#19330
Open
winfriedgerlach wants to merge 2 commits into
Open
#19329 fix ipv4 vs ipv6 in ip inet address matcher#19330winfriedgerlach wants to merge 2 commits into
winfriedgerlach wants to merge 2 commits into
Conversation
…to avoid ArrayIndexOutOfBoundsException Signed-off-by: Gerlach, Winfried <Winfried.Gerlach@draeger.com>
Signed-off-by: Gerlach, Winfried <Winfried.Gerlach@draeger.com>
aa61e39 to
0943cb1
Compare
winfriedgerlach
commented
Jun 12, 2026
| .format("IP address %s is too short for bitmask of length %d", requiredAddress, this.nMaskBits)); | ||
| } | ||
|
|
||
| private static InetAddress parse(String address) { |
Author
There was a problem hiding this comment.
this was unused residue from the earlier refactoring
winfriedgerlach
commented
Jun 12, 2026
| if (toCheck == null) { | ||
| return false; | ||
| } | ||
| if (!this.requiredAddress.getClass().equals(toCheck.getClass())) { |
Author
There was a problem hiding this comment.
this check was present before 7.1.0, I am just re-introducing it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19329