fix(compiler): handle subqueries in JOIN nullability inference #4280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed incorrect nullability inference when using subqueries with LEFT/RIGHT/FULL OUTER JOINs. When using subqueries in JOINs like: SELECT * FROM a LEFT JOIN (SELECT * FROM b) si ON si.a_id = a.id Columns from subquery 'si' were incorrectly treated as NOT NULL. Root cause: The isTableRequired() function did not handle *ast.RangeSubselect (subquery ranges). Solution: - Added *ast.RangeSubselect case to isTableRequired() - Match subqueries by their alias names - Verified all JOIN types (LEFT/RIGHT/FULL OUTER) work correctly Test coverage: - Added internal/endtoend/testdata/join_left_subquery/postgresql/ - Covers LEFT JOIN, RIGHT JOIN, and FULL OUTER JOIN patterns Fixes sqlc-dev#4117
dosubot
bot
added
size:L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed incorrect nullability inference when using subqueries with LEFT/RIGHT/FULL OUTER JOINs.
When using subqueries in JOINs like:
SELECT * FROM a LEFT JOIN (SELECT * FROM b) si ON si.a_id = a.id
Columns from subquery 'si' were incorrectly treated as NOT NULL.
Root cause: The isTableRequired() function did not handle *ast.RangeSubselect (subquery ranges).
Solution:
Test coverage:
Fixes #4117