Conversation
|
+1 |
asmallteapot
suggested changes
Jul 3, 2018
There was a problem hiding this comment.
Hi @dkavraal, thank you for submitting these changes! I left one minor note about a log statement that should be removed, and have one other question before merging: Is there any way we could restrict the cross-origins we allow to prevent any possible security issues?
| """Runs PonyDebugger's gateway""" | ||
| __subcommand__ = 'serve' | ||
|
|
||
| print "Running command-line. ok." |
There was a problem hiding this comment.
Could you please remove this log statement?
| page = None | ||
| devTools = None | ||
|
|
||
| def check_origin(self, origin): |
There was a problem hiding this comment.
Leaving myself a link to the documentation for the check_origin method.
Author
There was a problem hiding this comment.
Just saw. Sorry, for a while I won't have the chance to check this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/:404 error, devtools:403 error and Cross-origin-not-allowed error.
Issue#190
Issue#194
Thanks to comments of kenichi and julien gomez