cache: reject HTTPS responses with null handshake before cache write (#8962)#9395
Open
iVamsi wants to merge 1 commit intosquare:masterfrom
Open
cache: reject HTTPS responses with null handshake before cache write (#8962)#9395iVamsi wants to merge 1 commit intosquare:masterfrom
iVamsi wants to merge 1 commit intosquare:masterfrom
Conversation
Reject HTTPS responses with null handshake in Cache.put() and Cache.update() so malformed entries are never written to disk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the fix for
NullPointerExceptioninCache.Entry.writeTo()when an HTTPS response has a null handshake.Problem with previous fix (#9345)
The previous fix guarded
writeTo()withhandshake != null, which prevented the NPE but wrote malformed cache entries to disk. TheEntry(rawSource)read constructor still expects TLS data whenurl.isHttps, so these entries could never be read back — wasting disk I/O on entries that always result in a cache miss.Fix
Added guards in
Cache.put()andCache.update()to reject HTTPS responses with null handshake before serialization, so malformed entries are never written to disk. ThewriteTo()guard is kept as defense-in-depth.Tests updated
Three regression tests in
CacheTest:All tests now assert
cache.writeSuccessCount() == 0to verify no entries are written to disk.Fixes #8962