Skip to content

Conversation

@src-lua
Copy link
Owner

@src-lua src-lua commented Jul 8, 2025

No description provided.

src-lua added 3 commits July 8, 2025 09:18
Deleted the ObjReader library and its related header files from the vendor directory. Updated CMakeLists.txt to remove references to ObjReader. Added missing include for Prism/vector.hpp in Prism material.hpp to maintain required functionality.
@src-lua src-lua requested a review from Copilot July 8, 2025 12:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the Matrix transformation API, updates all call sites and tests to the new signatures, and enriches the public headers with Doxygen comments.

  • Changed Matrix::translation/scaling/rotation factories from dimension+list to explicit parameter APIs
  • Updated tests and usage in main.cpp to match the new Matrix API
  • Added Doxygen-style documentation to all public header files

Reviewed Changes

Copilot reviewed 28 out of 37 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/src/TransformationsTest.cpp Removed old dimension/list syntax, updated Matrix calls
tests/src/MatrixTest.cpp Adjusted default-constructor test, removed deprecated tests
src/main.cpp Wrapped long constructor call, updated Matrix calls
libs/Prism/include/Prism/**/*.hpp Added comprehensive Doxygen comments to public APIs
libs/Prism/src/matrix.cpp Reworked storage, proxies, and factory implementations
Comments suppressed due to low confidence (5)

tests/src/TransformationsTest.cpp:18

  • Update or remove this comment so it reflects the new Matrix::translation(tx, ty, tz) signature instead of the old dimension+list API.
    // CORREÇÃO: Passando a dimensão (3D) e a lista de valores

libs/Prism/include/Prism/objects.hpp:73

  • [nitpick] Returning the transform matrix by value may incur unnecessary copying. Consider returning a const Matrix& for better performance and consistency.
    Matrix getTransform() const {

tests/src/MatrixTest.cpp:54

  • [nitpick] Consider removing this commented-out test entirely if out-of-range checks are no longer supported to keep the test suite concise.
    // NOTA: A checagem de acesso fora dos limites não é mais feita para performance.

src/main.cpp:54

  • The angle 45 is passed directly—likely degrees—into a function expecting radians (cos(angle)). Convert degrees to radians or clarify the expected unit.
        teste * Prism::Matrix::rotation(45, {1, 0, 0}) * Prism::Matrix::scaling(0.5, 0.5, 0.5));

libs/Prism/include/Prism/Colormap.hpp:29

  • [nitpick] Avoid using namespace std; in a header file to prevent polluting the global namespace for all including translation units.
using namespace std;

@src-lua src-lua merged commit 15c3446 into main Jul 8, 2025
6 checks passed
@src-lua src-lua deleted the refactor/doxygen branch July 8, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants