Skip to content

Cleanup MODULE.bazel npm deps, add pnpm-workspace #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pcj merged 1 commit into from
Oct 6, 2025
Merged

Cleanup MODULE.bazel npm deps, add pnpm-workspace #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
load("@tsickle__0.46.3__links//:defs.bzl", npm_link_tsickle = "npm_link_imported_package")
load("@aspect_rules_ts//ts:defs.bzl", "ts_config")
load("@npm_tsickle//:defs.bzl", "npm_link_all_packages")

npm_link_all_packages(
name = "node_modules",
imported_links = [
npm_link_tsickle,
],
)

ts_config(
Expand Down
41 changes: 2 additions & 39 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,51 +21,15 @@ bazel_dep(name = "rules_nodejs", version = "6.5.0")

node = use_extension("@rules_nodejs//nodejs:extensions.bzl", "node", dev_dependency = False)
node.toolchain(node_version = "22.14.0")

use_repo(node, "nodejs_toolchains")

npm = use_extension("@aspect_rules_js//npm:extensions.bzl", "npm", dev_dependency = False)

npm.npm_translate_lock(
name = "npm_tsickle",
pnpm_lock = "//:pnpm-lock.yaml",
verify_node_modules_ignored = "//:.bazelignore",
)

use_repo(
npm,
"npm_tsickle",
)

npm.npm_import(
name = "tsickle__0.46.3",
integrity = "sha512-9PDXxOrtn2AdpvDin6FLGveXVGg8ec3ga8fh8mPR5lz9KtitW6riVgxgagicdfF1rgiBxDeH+5hVowPXhmZbYQ==",
package = "tsickle",
root_package = "",
version = "0.46.3",
)
use_repo(
npm,
"tsickle__0.46.3",
"tsickle__0.46.3__links",
)

# As an example, manually import a package using explicit coordinates.
# Just a demonstration of the syntax de-sugaring.
npm.npm_import(
name = "acorn__8.4.0",
bins = {"acorn": "./bin/acorn"},
integrity = "sha512-ULr0LDaEqQrMFGyQ3bhJkLsbtrQ8QibAseGZeaSUiT/6zb9IvIkomWHJIvgvwad+hinRAgsI51JcWk2yvwyL+w==",
package = "acorn",
# Root package where to link the package store
root_package = "",
version = "8.4.0",
)
use_repo(
npm,
"acorn__8.4.0",
"acorn__8.4.0__links",
)
use_repo(npm, "npm_tsickle")

pnpm = use_extension("@aspect_rules_js//npm:extensions.bzl", "pnpm")
use_repo(pnpm, "pnpm")
Expand All @@ -74,7 +38,6 @@ use_repo(pnpm, "pnpm")
# language ts configuration
# --------------------------------------------------------------------------------

rules_ts_ext = use_extension("@aspect_rules_ts//ts:extensions.bzl", "ext", dev_dependency = False)

rules_ts_ext = use_extension("@aspect_rules_ts//ts:extensions.bzl", "ext")
rules_ts_ext.deps(ts_version_from = "//:package.json")
use_repo(rules_ts_ext, "npm_typescript")
Loading
Loading