Fix blackbox endpoints when blackbox-exporter placement is customised#2062
Merged
Alex-Welsh merged 1 commit intostackhpc/2025.1from Jan 7, 2026
Merged
Fix blackbox endpoints when blackbox-exporter placement is customised#2062Alex-Welsh merged 1 commit intostackhpc/2025.1from
Alex-Welsh merged 1 commit intostackhpc/2025.1from
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses an issue with Prometheus blackbox exporter endpoint generation when the exporter and the Prometheus server are not located on the same host. The fix involves renaming an Ansible group variables file from prometheus-blackbox-exporter to prometheus, which correctly scopes the variables for the Prometheus server. A release note has also been added to document this change. The changes appear correct and effectively address the described problem.
MoteHue
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2025.1 version of #2026
@jovial isn't around at the moment so picking this one up in his place