-
Notifications
You must be signed in to change notification settings - Fork 33
feat(iaas): List NICs for Project #1242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iaas): List NICs for Project #1242
Conversation
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
a7928cb to
68446c6
Compare
rubenhoenle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, fix these 2 comments and we can merge this
relates to STACKITCLI-307 and #1214
Fixed tests and linter relates to STACKITCLI-307 and #1214
relates to STACKITCLI-307 and #1214 tests added network ids included in list of project NICs
985c0bd to
7ce2d60
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Description
relates to STACKITCLI-307 and #1214
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)