Skip to content

Conversation

@Manuelvaas
Copy link
Contributor

@Manuelvaas Manuelvaas commented Jan 21, 2026

Description

relates to STACKITCLI-307 and #1214

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@rubenhoenle rubenhoenle marked this pull request as ready for review January 27, 2026 10:12
@rubenhoenle rubenhoenle requested a review from a team as a code owner January 27, 2026 10:12
@github-actions
Copy link

github-actions bot commented Feb 7, 2026

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions bot added the Stale label Feb 7, 2026
@Manuelvaas Manuelvaas force-pushed the feature/STACKITCLI-307-list-NICs-for-project branch from a7928cb to 68446c6 Compare February 10, 2026 11:17
@rubenhoenle rubenhoenle removed the Stale label Feb 10, 2026
rubenhoenle
rubenhoenle previously approved these changes Feb 10, 2026
Copy link
Member

@rubenhoenle rubenhoenle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, fix these 2 comments and we can merge this

@Manuelvaas Manuelvaas force-pushed the feature/STACKITCLI-307-list-NICs-for-project branch from 985c0bd to 7ce2d60 Compare February 10, 2026 12:09
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/network-interface/list 58.75% (+7.81%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/network-interface/list/list.go 58.75% (+7.81%) 80 (+27) 47 (+20) 33 (+7) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/network-interface/list/list_test.go

@rubenhoenle rubenhoenle merged commit b047600 into main Feb 10, 2026
3 checks passed
@rubenhoenle rubenhoenle deleted the feature/STACKITCLI-307-list-NICs-for-project branch February 10, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants