feat(logs): Onboard access-token commands #1253

Manuelvaas · 2026-01-30T15:28:41Z

Description

Checklist

Issue was linked above
Code format was applied: make fmt
Examples were added / adjusted (see e.g. here)
Docs are up-to-date: make generate-docs (will be checked by CI)
Unit tests got implemented or updated
Unit tests are passing: make test (will be checked by CI)
No linter issues: make lint (will be checked by CI)

internal/cmd/beta/logs/access_token/create/create.go

rubenhoenle · 2026-01-30T16:57:40Z

internal/cmd/beta/logs/access_token/create/create.go

+				return fmt.Errorf("create log access-token : %w", err)
+			}
+
+			if resp == nil || resp.Id == nil {


As soon as you implement your unit tests you will note that this if statement belongs into outputResult 😉

after taking a second look: This check does not belong here. Belongs into outputResult IMO. No discussion needed from my perspective.

After taking a look at outputResult: This check isn't needed at all I guess

internal/cmd/beta/logs/access_token/create/create.go

internal/cmd/beta/logs/access_token/delete/delete.go

internal/cmd/beta/logs/access_token/delete_all/delete_all.go

internal/cmd/beta/logs/access_token/delete_all_expired/delete_all_expired.go

internal/cmd/beta/logs/access_token/list/list.go

internal/cmd/beta/logs/access_token/update/update.go

internal/pkg/services/logs/utils/utils.go

rubenhoenle

Before I even look into your next PR I will ask for implemented unit tests. It's ok this time. Just that you're aware for the future 😅

github-actions · 2026-02-07T03:41:28Z

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

relates to STACKITCLI-293

github-actions · 2026-02-11T13:31:17Z

Merging this branch will increase overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs	0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/access_token	0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/access_token/create	45.10% (+45.10%)	🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/access_token/delete	38.89% (+38.89%)	🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/access_token/delete_all	38.24% (+38.24%)	🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/access_token/delete_all_expired	38.24% (+38.24%)	🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/access_token/describe	74.00% (+74.00%)	🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/access_token/list	56.86% (+56.86%)	🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/access_token/update	40.00% (+40.00%)	🌟
github.com/stackitcloud/stackit-cli/internal/pkg/services/logs/utils	100.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/access_token/access_token.go	0.00% (ø)	10 (+10)	0	10 (+10)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/access_token/create/create.go	45.10% (+45.10%)	51 (+51)	23 (+23)	28 (+28)	🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/access_token/delete/delete.go	38.89% (+38.89%)	36 (+36)	14 (+14)	22 (+22)	🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/access_token/delete_all/delete_all.go	38.24% (+38.24%)	34 (+34)	13 (+13)	21 (+21)	🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/access_token/delete_all_expired/delete_all_expired.go	38.24% (+38.24%)	34 (+34)	13 (+13)	21 (+21)	🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/access_token/describe/describe.go	74.00% (+74.00%)	50 (+50)	37 (+37)	13 (+13)	🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/access_token/list/list.go	56.86% (+56.86%)	51 (+51)	29 (+29)	22 (+22)	🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/access_token/update/update.go	40.00% (+40.00%)	45 (+45)	18 (+18)	27 (+27)	🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/logs/logs.go	0.00% (ø)	5 (+1)	0	5 (+1)
github.com/stackitcloud/stackit-cli/internal/pkg/services/logs/utils/utils.go	100.00% (ø)	16 (+8)	16 (+8)	0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.