fix(releaser): don't put license in root directory on apt installation #1285
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to STACKITCLI-324 and #1265
Description
The license file was put in the root directory
/LICENSE.md. Now it's placed under/usr/share/doc/stackit/copyrightwhich seems to be common for APT packages.Testing instructions
I built a test environment for you with docker which allows you to check if the file is still located in
/LICENSE.mdor in/usr/share/doc/stackit/copyright. Read #1265 and the script, then you should understand roughly what happens and what's your job to test.To setup the test environment create a file named
Dockerfilein the root of the repo and a file namedtest.shwith the following contents.Run this script (including your manual testing steps) once for the
mainbranch and once with my bugfix branch to verify the old and the new behavior.Then run:
./test.shAs I'm no MacOS user I had to adjust the goreleaser config a little bit (comment out the MacOS signing stuff and the snapcraft stuff). So it looks like this for the fixed version for me:
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)