feat(resourcemanager): refactor wait handler to use helper struct#6013
Open
feat(resourcemanager): refactor wait handler to use helper struct#6013
Conversation
rubenhoenle
reviewed
Mar 23, 2026
| getFails: false, | ||
| getNotFound: false, | ||
| projectState: resourcemanager.LIFECYCLESTATE_DELETING, | ||
| wantErr: true, |
Member
There was a problem hiding this comment.
Suggested change
| wantErr: true, | |
| wantErr: false, |
resourcemanager.LIFECYCLESTATE_DELETING is not part of the ErrorState slice, should there really be an error then?
Contributor
Author
There was a problem hiding this comment.
Yes it's not part of the ErrorState slice but the state remains always on the pending state, so the waiter runs into a timeout and throws an timeout error.
To prevent this we would need a different approach in the mocks, where we can set a list of responses, to simulate the transition
Contributor
Author
There was a problem hiding this comment.
I changed the tests to cover also state transitions 60157ae
marceljk
force-pushed
the
feat/STACKITSDK-389-refactor-resourcemanager-wait-handler
branch
from
60157ae to
a6c8ce2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITSDK-389
Checklist
make fmtexamples/directory)make test(will be checked by CI)make lint(will be checked by CI)