Skip to content

Conversation

@Fyusel
Copy link
Contributor

@Fyusel Fyusel commented Feb 9, 2026

Description

relates to #1234

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@Fyusel Fyusel requested a review from a team as a code owner February 9, 2026 08:48
@Fyusel Fyusel force-pushed the feat/observability-recording-rules branch 2 times, most recently from 7a1b631 to b00afec Compare February 9, 2026 08:51
Signed-off-by: Alexander Dahmen <alexander.dahmen@inovex.de>
@Fyusel Fyusel force-pushed the feat/observability-recording-rules branch from b00afec to 97bc08c Compare February 9, 2026 09:19
cgoetz-inovex
cgoetz-inovex previously approved these changes Feb 9, 2026
Co-authored-by: cgoetz-inovex <carlo.goetz@inovex.de>
@Fyusel Fyusel force-pushed the feat/observability-recording-rules branch from d86f85b to cfd61a5 Compare February 9, 2026 10:35
@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability/alertgroup 33.97% (-1.45%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability/alertgroup/datasource.go 0.00% (ø) 39 0 39
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability/alertgroup/resource.go 39.91% (-2.38%) 223 (+22) 89 (+4) 134 (+18) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability/alertgroup/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability/observability_acc_test.go

@Fyusel Fyusel merged commit e99da3b into main Feb 9, 2026
3 checks passed
@Fyusel Fyusel deleted the feat/observability-recording-rules branch February 9, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants