Skip to content

feat(dns) add timeouts to dns resources and datasources#1345

Merged
cgoetz-inovex merged 6 commits intomainfrom
feat/STACKITTPR-542-set-timeouts
Apr 1, 2026
Merged

feat(dns) add timeouts to dns resources and datasources#1345
cgoetz-inovex merged 6 commits intomainfrom
feat/STACKITTPR-542-set-timeouts

Conversation

@cgoetz-inovex
Copy link
Copy Markdown
Contributor

STACKITTPR-542

Description

relates to #1234

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@cgoetz-inovex cgoetz-inovex requested a review from a team as a code owner March 31, 2026 14:27
marceljk
marceljk previously approved these changes Apr 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/.github/docs/contribution-guide 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/core 21.62% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dns 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dns/recordset 18.11% (-2.58%) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dns/zone 19.29% (-2.58%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/.github/docs/contribution-guide/resource.go 0.00% (ø) 0 0 0
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/core/core.go 21.62% (ø) 37 8 29
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dns/recordset/datasource.go 0.00% (ø) 48 (+6) 0 48 (+6)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dns/recordset/resource.go 22.12% (-3.14%) 217 (+27) 48 169 (+27) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dns/zone/datasource.go 0.00% (ø) 64 (+6) 0 64 (+6)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dns/zone/resource.go 25.00% (-3.57%) 216 (+27) 54 162 (+27) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dns/dns_test.go

@cgoetz-inovex cgoetz-inovex merged commit 5c52e10 into main Apr 1, 2026
3 checks passed
@cgoetz-inovex cgoetz-inovex deleted the feat/STACKITTPR-542-set-timeouts branch April 1, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants