chore(iaas): switch to new SDK structure#1417
Open
rubenhoenle wants to merge 1 commit into
Open
Conversation
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
rubenhoenle
force-pushed
the
chore/STACKITTPR-557-iaas-sdk-migration
branch
from
1655262 to
b50e572
Compare
relates to STACKITTPR-557
rubenhoenle
force-pushed
the
chore/STACKITTPR-557-iaas-sdk-migration
branch
from
b50e572 to
a543c09
Compare
Merging this branch changes the coverage (11 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
marceljk
reviewed
May 12, 2026
| configModel.VideoModel = types.StringPointerValue(imageResp.Config.GetVideoModel()) | ||
| configModel.VirtioScsi = types.BoolPointerValue(new(imageResp.Config.GetVirtioScsi())) | ||
| configModel.VideoModel = types.StringPointerValue(imageResp.Config.VideoModel.Get()) | ||
| configModel.VirtioScsi = types.BoolPointerValue(imageResp.Config.VirtioScsi) |
Contributor
There was a problem hiding this comment.
The change from GetVirtioScsi() to VirtioScsi results in a bug. GetVirtioScsi() returned always a boolean, even if the API didn't responded with one. And the direct access can results now in a state drift.
Probably this is an API issue, didn't checked it in detail. Can be reproduced by running the TestAccImageMax acc test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITTPR-557
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)