feat(ske): add ephemeral ske kubeconfig#1448
Open
h3adex wants to merge 1 commit into
Open
Conversation
h3adex
force-pushed
the
feat/add-ephemeral-resource-ske-kubeconfig
branch
2 times, most recently
from
e7a7211 to
21ffd96
Compare
h3adex
force-pushed
the
feat/add-ephemeral-resource-ske-kubeconfig
branch
from
21ffd96 to
42e7091
Compare
Contributor
Author
|
|
h3adex
force-pushed
the
feat/add-ephemeral-resource-ske-kubeconfig
branch
9 times, most recently
from
638204f to
ad810c1
Compare
Contributor
Author
|
E2E Tests |
h3adex
force-pushed
the
feat/add-ephemeral-resource-ske-kubeconfig
branch
from
ad810c1 to
4ee4a4a
Compare
Signed-off-by: Mauritz Uphoff <mauritz.uphoff@stackit.cloud>
h3adex
force-pushed
the
feat/add-ephemeral-resource-ske-kubeconfig
branch
from
4ee4a4a to
cd6a220
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
stackit_ske_kubeconfigephemeral resource. The default expiration has been reduced to 30 minutes. Since these credentials only need to persist for the duration of a Terraform run, where even slow Helm deployments rarely exceed a 10-15 minute window, a 60-minute expiration is excessive.Tested example code:
https://professional-service.git.onstackit.cloud/professional-service-best-practices/professional-service/pulls/18
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)