feat(vpn): Onboarding VPN gateway#1453
Draft
s-inter wants to merge 11 commits into
Draft
Conversation
rubenhoenle
reviewed
May 11, 2026
| resource.TestCheckResourceAttrSet("stackit_vpn_gateway.gateway", "gateway_id"), | ||
| resource.TestCheckResourceAttrSet("stackit_vpn_gateway.gateway", "state"), | ||
| ), | ||
| }, |
rubenhoenle
reviewed
May 11, 2026
| resource.TestCheckResourceAttr("stackit_vpn_gateway.gateway", "bgp.local_asn", testutil.ConvertConfigVariable(gatewayMaxVars["local_asn"])), | ||
| resource.TestCheckResourceAttrSet("stackit_vpn_gateway.gateway", "gateway_id"), | ||
| ), | ||
| }, |
rubenhoenle
reviewed
May 11, 2026
| }, | ||
| "region": schema.StringAttribute{ | ||
| Description: schemaDescriptions["region"], | ||
| Required: true, |
Member
There was a problem hiding this comment.
region is never required, see other resource and datasource implementations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Draft only:
The VPN Waiter PR is currently blocked on the VPN API V1 integration into the SDK. But this PR requires the Waiter to be present.
To test this PR locally, check out the
si-vpn-waiterbranch in the SDK and add areplacedirective forgithub.com/stackitcloud/stackit-sdk-go/services/vpnpointing to your local version ingo.mod.relates to STACKITTPR-633)
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)