fix(secretsmanager): Allow inplace update of user description#1455
Draft
j1n-o9r wants to merge 1 commit into
Draft
fix(secretsmanager): Allow inplace update of user description#1455j1n-o9r wants to merge 1 commit into
j1n-o9r wants to merge 1 commit into
Conversation
… tf schema definition indicating a replacement. Therefore, I have adapted unit tests and acceptance tests. Ran into 500 errors in acceptance tests and started a discussion with the central services team.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A bug was found where the API definition suggests an in place update of the user description of a secrets manager user but the TFP replaces the secrets manager instance instead. See #882
relates to STACKITTPR-649
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)