-
Notifications
You must be signed in to change notification settings - Fork 29
chore(CI): Konflux build to UBI9 #2815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davdhacs
wants to merge
16
commits into
master
Choose a base branch
from
konflux-ubi9-migration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6897630
Migrate Konflux build to UBI9/RHEL9 base images
davdhacs 23cacca
Add hermetic RPM prefetch for RHEL9 packages
davdhacs 3f88be9
remove duplicated cachi2 env sourcing
davdhacs 2cbf118
Use bare: true context for RPM lockfile generation
davdhacs 7f0efb4
Regenerate rpms.rhel.repo and rpms.lock.yaml with source RPMs enabled
davdhacs a9a6866
remove 9 from repo suffix
davdhacs 094e8aa
Merge master (keep UBI9 rpms)
davdhacs bc767da
Fix rpms.rhel.repo to use $basearch variable in name fields
davdhacs e01bd2b
Merge branch 'master' into konflux-ubi9-migration
davdhacs 6dcdf3d
empty commit
davdhacs ae9872f
restore "-rhel9" image suffix
davdhacs b646a09
Add elfutils-libelf runtime dependency to UBI9 image
davdhacs 2ca1e46
Remove unnecessary enabled_metadata=1 from source repos
davdhacs 8cb31c2
remove trailing newline
davdhacs 7803a02
Merge branch 'master' into konflux-ubi9-migration
davdhacs fc62411
Merge branch 'master' into konflux-ubi9-migration
davdhacs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ packages: | |
| - make | ||
| - wget | ||
| - unzip | ||
| - clang-19.1.7 | ||
| - clang-20.1.8 | ||
| - llvm | ||
| - cmake | ||
| - gcc-c++ | ||
|
|
@@ -26,6 +26,7 @@ packages: | |
| # final stage in collector/container/konflux.Dockerfile | ||
| - tbb | ||
| - c-ares | ||
| - elfutils-libelf | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ovalenti It looks like this is needed now. Is this valid?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| contentOrigin: | ||
| repofiles: [ "rpms.rhel.repo" ] | ||
| context: | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check with @stackrox/collector-team if this clang version is compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The kind of issues we get with incompatible versions of clang are usually detected pretty well by integration tests. Making sure that all the tests pass should be enough.
I think that clang-20 is already what is used for upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty. This is the latest stable clang I found for ubi9. @ovalenti would it be better to un-pin clang for ubi9?