Skip to content

ROX-33567: Use vpc_inventory to retrieve IBM VMs#3129

Draft
ovalenti wants to merge 1 commit intomasterfrom
ovalenti/ibm-vpc-inventory
Draft

ROX-33567: Use vpc_inventory to retrieve IBM VMs#3129
ovalenti wants to merge 1 commit intomasterfrom
ovalenti/ibm-vpc-inventory

Conversation

@ovalenti
Copy link
Contributor

@ovalenti ovalenti commented Mar 20, 2026

Description

The IBM cloudcollection provides an inventory plugin. We used to create an inventory yaml file for the VMs we create in the IBM cloud, and this seems to have led to VM leaks. By using the inventory, we hope to address those leak issues (and also to simplify housekeeping).

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.

For more details, ref the Confluence page about this section.

- no more inventory file generation
- VMs have tags similar to what is done in GCP
@ovalenti ovalenti self-assigned this Mar 20, 2026
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.38%. Comparing base (d849979) to head (20942f0).
⚠️ Report is 4 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3129   +/-   ##
=======================================
  Coverage   27.38%   27.38%           
=======================================
  Files          95       95           
  Lines        5427     5427           
  Branches     2548     2548           
=======================================
  Hits         1486     1486           
  Misses       3214     3214           
  Partials      727      727           
Flag Coverage Δ
collector-unit-tests 27.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants