Skip to content

Private net sanity check#3130

Draft
ovalenti wants to merge 3 commits intomasterfrom
ovalenti/private-net-sanity-check
Draft

Private net sanity check#3130
ovalenti wants to merge 3 commits intomasterfrom
ovalenti/private-net-sanity-check

Conversation

@ovalenti
Copy link
Contributor

Note

The initial content of this PR was authored using Claude Code.

Description

For scalability reasons, Collector filters addresses in a different way when they are "public" or "private". In particular, addresses in the "public" ranges are aggregated and don't appear individually on the Network Graph.

We have seen a few occurrences of customers making use of non "private" addresses for the PODs and services of their clusters ; leading to internal traffic not appearing as expected in the interface.

This PR enumerates the local network interfaces and displays the addresses with associated netmask. When a non "private" address is found, a warning message is produced.

This is expected to be useful when troubleshooting because the addresses where not available in the log before, but also, the customers may be able to fix the situation by themselves.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.

For more details, ref the Confluence page about this section.

@ovalenti ovalenti self-assigned this Mar 20, 2026
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 41.17647% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.51%. Comparing base (2cc1dcd) to head (85ec895).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
collector/lib/NetworkConnection.cpp 52.50% 19 Missing ⚠️
collector/lib/HostHeuristics.cpp 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3130      +/-   ##
==========================================
+ Coverage   27.38%   27.51%   +0.12%     
==========================================
  Files          95       95              
  Lines        5427     5478      +51     
  Branches     2548     2572      +24     
==========================================
+ Hits         1486     1507      +21     
- Misses       3214     3244      +30     
  Partials      727      727              
Flag Coverage Δ
collector-unit-tests 27.51% <41.17%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants