Skip to content

fix: properly format credential plugin request#199

Merged
porridge merged 2 commits into
masterfrom
fix/request-format
Jun 10, 2026
Merged

fix: properly format credential plugin request#199
porridge merged 2 commits into
masterfrom
fix/request-format

Conversation

@porridge

Copy link
Copy Markdown
Collaborator

json.Marshal does not produce the apiVersion and kind fields, required by the protocol and actually checked by the AWS ECR plugin, unlike the GKE one which happened to be more forgiving.

This uses the k8s.io/apimachinery/pkg/runtime/serializer package and adds a test.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 4f1135f6-f9c1-412d-a794-1c8a73fb2357

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/request-format

Comment @coderabbitai help to get the list of available commands and usage tips.

@porridge porridge merged commit 9006eb5 into master Jun 10, 2026
5 checks passed
@porridge porridge deleted the fix/request-format branch June 10, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants