Skip to content

[6.x] Fix adding sets to replicators nested inside Grid/Group fields #13723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonvarga merged 6 commits into from
Jan 29, 2026
Merged

[6.x] Fix adding sets to replicators nested inside Grid/Group fields #13723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d2d06db
Add failing test
duncanmcclean Jan 29, 2026
0c9c6f6
Add handling for group fields
duncanmcclean Jan 29, 2026
4c356aa
whoops, rename test
duncanmcclean Jan 29, 2026
4f63957
Add failing test for grids
duncanmcclean Jan 29, 2026
8b2f5d3
Add handling for grid fields
duncanmcclean Jan 29, 2026
0a51b25
Merge branch '6.x' into replicator-inside-grid-inside-replicator
jasonvarga Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/Http/Controllers/CP/Fieldtypes/ReplicatorSetController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ private function getReplicatorField(Blueprint $blueprint, string $field): Field

private function getConfig(array $config, array $remainingFieldPathComponents): array
{
$isGroupOrGrid = isset($config['type']) && in_array($config['type'], ['group', 'grid']);
$isReplicator = isset($config['type']) && in_array($config['type'], ['bard', 'replicator']);

if ($isReplicator) {
Expand All @@ -88,6 +89,14 @@ private function getConfig(array $config, array $remainingFieldPathComponents):
return $this->getConfig($flattenedSets, $remainingFieldPathComponents);
}

if ($isGroupOrGrid) {
array_shift($remainingFieldPathComponents);

$fields = $this->resolveFields($config['fields'] ?? []);

return $this->getConfig($fields[$remainingFieldPathComponents[0]]['field'], $remainingFieldPathComponents);
}

$fields = $this->resolveFields($config[$remainingFieldPathComponents[0]]['fields']);

array_shift($remainingFieldPathComponents);
Expand Down
173 changes: 173 additions & 0 deletions tests/Fieldtypes/ReplicatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -932,6 +932,179 @@ public function it_can_return_set_defaults_for_nested_sets()
], $response->json('new'));
}

/**
* We're purposefully naming the sets the same as its nested field to replicate the reported issue.
*
* @see https://github.com/statamic/cms/issues/13714
*/
#[Test]
public function it_can_return_set_defaults_for_replicator_inside_group()
{
$this->partialMock(RowId::class, function (MockInterface $mock) {
$mock->shouldReceive('generate')->andReturn('random-string-1', 'random-string-2');
});

$pageBuilder = Fieldset::make('page_builder')->setContents(['fields' => [
['handle' => 'page_builder', 'field' => ['type' => 'replicator', 'sets' => [
'replicator_set_group' => [
'sets' => [
'cards_slider' => [
'fields' => [
[
'handle' => 'cards_slider',
'field' => [
'type' => 'group',
'fields' => [
[
'handle' => 'slider',
'field' => [
'type' => 'group',
'fields' => [
[
'handle' => 'cards',
'field' => [
'type' => 'replicator',
'sets' => [
'replicator_set_group' => [
'sets' => [
'card' => [
'fields' => [
['handle' => 'card_content', 'field' => ['type' => 'text', 'default' => 'the default']],
],
],
],
],
],
],
],
],
],
],
],
],
],
],
],
],
],
]]],
]]);

Fieldset::shouldReceive('find')->with('page_builder')->andReturn($pageBuilder);

$blueprint = Facades\Blueprint::make()->setHandle('default')->setNamespace('collections.pages');
$blueprint->setContents([
'sections' => [
'main' => [
'fields' => [
['import' => 'page_builder'],
],
],
],
]);

Facades\Blueprint::partialMock();
Facades\Blueprint::shouldReceive('find')->with('collections.pages.default')->andReturn($blueprint);

$response = $this
->actingAs(tap(Facades\User::make()->makeSuper())->save())
->postJson(cp_route('replicator-fieldtype.set'), [
'blueprint' => 'collections.pages.default',
'field' => 'page_builder.cards_slider.cards_slider.slider.cards',
'set' => 'card',
])
->assertOk();

$this->assertEquals([
'card_content' => 'the default',
], $response->json('defaults'));

$this->assertEquals([
'_' => '_',
'card_content' => null,
], $response->json('new'));
}

#[Test]
public function it_can_return_set_defaults_for_replicator_inside_grid()
{
$this->partialMock(RowId::class, function (MockInterface $mock) {
$mock->shouldReceive('generate')->andReturn('random-string-1', 'random-string-2');
});

$pageBuilder = Fieldset::make('page_builder')->setContents(['fields' => [
['handle' => 'page_builder', 'field' => ['type' => 'replicator', 'sets' => [
'replicator_set_group' => [
'sets' => [
'cards_slider' => [
'fields' => [
[
'handle' => 'cards_slider',
'field' => [
'type' => 'grid',
'fields' => [
[
'handle' => 'cards',
'field' => [
'type' => 'replicator',
'sets' => [
'replicator_set_group' => [
'sets' => [
'card' => [
'fields' => [
['handle' => 'card_content', 'field' => ['type' => 'text', 'default' => 'the default']],
],
],
],
],
],
],
],
],
],
],
],
],
],
],
]]],
]]);

Fieldset::shouldReceive('find')->with('page_builder')->andReturn($pageBuilder);

$blueprint = Facades\Blueprint::make()->setHandle('default')->setNamespace('collections.pages');
$blueprint->setContents([
'sections' => [
'main' => [
'fields' => [
['import' => 'page_builder'],
],
],
],
]);

Facades\Blueprint::partialMock();
Facades\Blueprint::shouldReceive('find')->with('collections.pages.default')->andReturn($blueprint);

$response = $this
->actingAs(tap(Facades\User::make()->makeSuper())->save())
->postJson(cp_route('replicator-fieldtype.set'), [
'blueprint' => 'collections.pages.default',
'field' => 'page_builder.cards_slider.cards_slider.cards',
'set' => 'card',
])
->assertOk();

$this->assertEquals([
'card_content' => 'the default',
], $response->json('defaults'));

$this->assertEquals([
'_' => '_',
'card_content' => null,
], $response->json('new'));
}

public static function groupedSetsProvider()
{
return [
Expand Down