[6.x] Fix asset selector padding #13737
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Does that page even need it though? If I remove it, it still looks fine. |
Contributor
Could it be that this was added a while back to fix the drop targets for when dragging an asset to upload it? |
Contributor
|
Yeah, I think it was: https://github.com/statamic/cms/pull/13361/changes |
jasonvarga
requested changes
Jan 29, 2026
Member
jasonvarga
left a comment
jasonvarga
left a comment
There was a problem hiding this comment.
Good catch @robdekort. In that case, this PR breaks that.
- We need the h-full on Browse.vue - Don't remove it, contrary to what I suggested.
- When you have the asset fieldtype stack open, when you drag a file over the stack on blank space under the listing, you would get the drop zone. Now with this PR, you dont.
This reverts commit 2b75f62.
The Panel has its own padding bottom, but we need `pb-1` here for it to show.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the Asset Selector's bottom padding wasn't showing due to
h-fullbeing applied to theAssetBrowsercomponent.This PR fixes it by only applying the
h-fullclass on the page that needs it.Closes #13730