Skip to content

[6.x] Abort 404 when asset is not found in AssetsController #13740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mynetx wants to merge 1 commit into from
Closed

[6.x] Abort 404 when asset is not found in AssetsController #13740

mynetx wants to merge 1 commit into from
+4 −0

Conversation

@mynetx
Copy link
Contributor

@mynetx mynetx commented Jan 29, 2026

Summary

  • Add abort_if(! $asset, 404) null guard after Asset::find() in show() and download() methods of AssetsController
  • Prevents 500 errors when an asset cannot be found, returning a proper 404 instead

Test plan

  • Verify requesting a non-existent asset via show() returns 404
  • Verify requesting a non-existent asset via download() returns 404
  • Verify existing asset requests still work normally

Fixes #13739

@mynetx
Abort 404 when asset is not found in AssetsController
dd2cd25 
Add null guard after Asset::find() in show() and download() methods
to return a 404 instead of a 500 error when the asset doesn't exist.

Fixes statamic#13739
@jasonvarga
Copy link
Member

jasonvarga commented Jan 30, 2026

We'll merge the 5.x PR into 6.x

@jasonvarga jasonvarga closed this Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AssetsController::show() returns 500 when Asset::find() returns null

2 participants

@mynetx @jasonvarga