[5.x] Abort 404 when asset is not found in AssetsController #13741
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add null guard after Asset::find() in show() and download() methods to return a 404 instead of a 500 error when the asset doesn't exist. Fixes statamic#13739
Contributor
|
V5 bug fixes are supported till March 2026. So I'd assume you don't need two separate PRs for v5 and v6. It should be enough to have the v5 one. Changes to v5 should be merged before every v6 release, at least till March or if there's a security issue. https://statamic.dev/knowledge-base/release-schedule-support-policy#support-policy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
abort_if(! $asset, 404)null guard afterAsset::find()inshow()anddownload()methods ofAssetsControllerTest plan
show()returns 404download()returns 404Fixes #13739