Skip to content

[6.x] Nested bard fixed toolbars - remove sticky stacking approach #13750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonvarga merged 4 commits into from
Jan 30, 2026
Merged

[6.x] Nested bard fixed toolbars - remove sticky stacking approach #13750

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
49a8e43
Bard fixed toolbar - Don't try and cascade sticky positioning because…
jaygeorge Jan 30, 2026
0c9283b
Typos
jaygeorge Jan 30, 2026
036e504
Where a Bard fieldtype with a fixed toolbar has a nested Bard fieldty…
jaygeorge Jan 30, 2026
1d0ea70
Fix the toolbar position for smaller viewports
jaygeorge Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions resources/css/components/fieldtypes/bard.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@
}
}

/* When there's a fixed toolbar the the bard editor should have square radius in the top corners to but up against the bottom of the toolbar */
/* When there's a fixed toolbar the bard editor should have square radius in the top corners to but up against the bottom of the toolbar */
.bard-fieldtype:has(> &) {
.bard-editor:focus-within {
border-top-left-radius: 0!important;
Expand All @@ -154,7 +154,7 @@
.bard-fixed-toolbar {
z-index: var(--z-index-portal);
position: sticky;
@apply -top-2;
@apply sm:-top-2;
/* Prevent the sticky toolbar from hitting the very end of container, which causes it to overlap the container's border-radius */
margin-block-end: 8px;
/* Pull the subsequent element up to compensate for this. The focus ring adjustment here keeps the focus ring from disappearing into the toolbar, which would make the focus ring appear bottom heavy. */
Expand All @@ -164,10 +164,17 @@
}
}

/* Bard field with a fixed toolbar > then another fixed toolbar inside this */
.bard-fieldtype:has(> .bard-fixed-toolbar) .bard-content .bard-fixed-toolbar {
@apply top-8;
/* Where a Bard fieldtype with a fixed toolbar... */
.bard-fieldtype:has(> .bard-fixed-toolbar) {
/* has a nested Bard fieldtype with a fixed toolbar _with focus_ */
&:has(.bard-fieldtype .bard-content:focus) {
/* release the sticky positioning so that it doesn't cover the focused Bard toolbar */
> .bard-fixed-toolbar {
position: unset;
}
}
}

/* Bard > Grid > Bard */
.bard-content .grid-fieldtype .bard-fixed-toolbar {
@apply top-16;
Expand All @@ -178,7 +185,7 @@
top: -24px;
}

/* Responive Wangjangling */
/* Responsive Wangjangling */
@media (width >= theme(--breakpoint-md)) {
/* Fixed toolbar below fixed global header */
.bard-fixed-toolbar {
Expand Down
Loading