[6.x] Fix asset index fieldtype slice length #13757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While backporting #13708 to v5, I realized that the whole "show the 6th asset in place of the +1" logic wasn't even working as described. When you had 6 assets, you'd only get 5 and no +1.
The slice length is fixed now.
Also, it was using
splice, which in Vue 2 was causing an infinite re-render. Changingsplicetoslicefixes that -splicemodifies the original array andslicemakes a new one. Doesn't have that problem in Vue 3 but doesn't hurt to fix it.