Skip to content

[5.x] Allow external redirects from Form::getSubmissionRedirect #14318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonvarga merged 2 commits into from
Mar 22, 2026
+9 −5
Merged

[5.x] Allow external redirects from Form::getSubmissionRedirect #14318

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d12fde2
Allow external redirects from Form::getSubmissionRedirect
jasonvarga Mar 22, 2026
38186c4
Refactor formSuccessRedirect to use early return for developer-define…
jasonvarga Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/Http/Controllers/FormController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,7 @@ private function formSuccess($params, $submission, $silentFailure = false)
]);
}

$response = $redirect && ! \Statamic\Facades\URL::isExternalToApplication($redirect)
? redirect($redirect)
: back();
$response = $redirect ? redirect($redirect) : back();

if (! \Statamic\Facades\URL::isExternal($redirect)) {
session()->flash("form.{$submission->form()->handle()}.success", __('Submission successful.'));
Expand All @@ -169,8 +167,14 @@ private function formSuccess($params, $submission, $silentFailure = false)

private function formSuccessRedirect($params, $submission)
{
if (! $redirect = Form::getSubmissionRedirect($submission)) {
$redirect = Arr::get($params, '_redirect');
if ($redirect = Form::getSubmissionRedirect($submission)) {
return $redirect;
}

$redirect = Arr::get($params, '_redirect');

if ($redirect && \Statamic\Facades\URL::isExternalToApplication($redirect)) {
return null;
}

return $redirect;
Expand Down
Loading