Disable IsPage till perf regression is fixed#35
Open
atiq-cs wants to merge 1 commit intostatiqdev:mainfrom
Open
Disable IsPage till perf regression is fixed#35atiq-cs wants to merge 1 commit intostatiqdev:mainfrom
atiq-cs wants to merge 1 commit intostatiqdev:mainfrom
Conversation
- reverses commit 8c248f0 partially ref. statiqdev#24, rel. statiqdev#25
atiq-cs
force-pushed
the
disable_pages
branch
from
ab938d2 to
0a69a4f
Compare
Contributor
Author
|
@daveaglick @rdeago please have a look. |
Member
|
Note: This is related to the discussion in #34 - going to do some work there to try and uncover the source of the slowness before merging this fix, since the code removed here will change the behavior of the theme (specifically, the navbar will show different things before and after the change). We'll circle back to this PR after trying to get to the bottom of why it's needed in the first place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverse commit 8c248f0 partially
ref. #24, rel. #25
For our large blog, build completes within 12 minutes with this change. Without this change, build keep running forever!