feat: add blas/ext/base/gzero-to#11191
Open
headlessNode wants to merge 3 commits intostdlib-js:developfrom
Open
feat: add blas/ext/base/gzero-to#11191headlessNode wants to merge 3 commits intostdlib-js:developfrom
blas/ext/base/gzero-to#11191headlessNode wants to merge 3 commits intostdlib-js:developfrom
Conversation
stdlib-bot
added
the
BLAS
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
headlessNode
added
Feature
kgryte
reviewed
Mar 28, 2026
| * gzeroTo( x.length, toAccessorArray( x ), 1 ); | ||
| * // x => [ 0.0, 1.0, 2.0, 3.0 ] | ||
| */ | ||
| <T = unknown>( N: number, x: AccessorArrayLike<T>, strideX: number ): AccessorArrayLike<T>; |
Member
There was a problem hiding this comment.
Study how we do things in
. What are you doing here with overloads is (1) unnecessary and (2) loses type specificity.
kgryte
reviewed
Mar 28, 2026
Comment on lines
+29
to
+30
| gzeroTo( x.length, x, 1 ); // $ExpectType Collection<number> | ||
| gzeroTo( x.length, new AccessorArray( x ), 1 ); // $ExpectType AccessorArrayLike<number> |
kgryte
reviewed
Mar 28, 2026
Comment on lines
+87
to
+88
| gzeroTo.ndarray( x.length, x, 1, 0 ); // $ExpectType Collection<number> | ||
| gzeroTo.ndarray( x.length, new AccessorArray( x ), 1, 0 ); // $ExpectType AccessorArrayLike<number> |
kgryte
reviewed
Mar 28, 2026
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Mar 28, 2026
kgryte
reviewed
Mar 28, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
requested changes
Mar 28, 2026
Member
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
Apart from the TS declarations, this is now looking good.
kgryte
added
the
Needs Changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves stdlib-js/metr-issue-tracker#229.
Description
This pull request:
blas/ext/base/gzero-toRelated Issues
This pull request has the following related issues:
blas/ext/base/gzero-tometr-issue-tracker#229Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Written primarily by Claude Code.
@stdlib-js/reviewers