Skip to content

refactor: replace isMatrixTranspose with resolveStr in blas/base/dgemm#12131

Merged
kgryte merged 3 commits into
stdlib-js:developfrom
MeKaustubh07:refactor/dgemm
May 14, 2026
Merged

refactor: replace isMatrixTranspose with resolveStr in blas/base/dgemm#12131
kgryte merged 3 commits into
stdlib-js:developfrom
MeKaustubh07:refactor/dgemm

Conversation

@MeKaustubh07
Copy link
Copy Markdown
Member

@MeKaustubh07 MeKaustubh07 commented May 14, 2026

Description

What is the purpose of this pull request?

This pull request:

  • docs: replace isMatrixTranspose with resolveStr in blas/base/dgemm

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • #{{TODO: add related issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@MeKaustubh07 MeKaustubh07 requested a review from a team May 14, 2026 13:18
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels May 14, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented May 14, 2026

Coverage Report

Package Statements Branches Functions Lines
blas/base/dgemm $\color{green}843/843$
$\color{green}+0.00%$
$\color{green}118/118$
$\color{green}+0.00%$
$\color{green}8/8$
$\color{green}+0.00%$
$\color{green}843/843$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@MeKaustubh07
Copy link
Copy Markdown
Member Author

@kgryte since this pattern seems applicable across multiple blas/base/* packages, would it make sense to create an RFC to standardize the approach across BLAS Level 2/3 packages before proceeding further?

@MeKaustubh07 MeKaustubh07 added GSoC Google Summer of Code. gsoc: 2026 Google Summer of Code (2026). labels May 14, 2026
@kgryte
Copy link
Copy Markdown
Member

kgryte commented May 14, 2026

@MeKaustubh07 I suggest just going ahead and opening a PR which updates all applicable BLAS level 2/3 packages.

@kgryte kgryte changed the title docs: replace isMatrixTranspose with resolveStr in blas/base/dgemm refactor: replace isMatrixTranspose with resolveStr in blas/base/dgemm May 14, 2026
Comment thread lib/node_modules/@stdlib/blas/base/dgemm/lib/dgemm.js Outdated
Comment thread lib/node_modules/@stdlib/blas/base/dgemm/lib/dgemm.js Outdated
Comment thread lib/node_modules/@stdlib/blas/base/dgemm/lib/ndarray.js Outdated
Comment thread lib/node_modules/@stdlib/blas/base/dgemm/lib/ndarray.js Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after some minor clean-up.

@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 4 and removed Needs Review A pull request which needs code review. labels May 14, 2026
@kgryte kgryte merged commit 20f5ae9 into stdlib-js:develop May 14, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. GSoC Google Summer of Code. gsoc: 2026 Google Summer of Code (2026). review: 4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants