-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: add route and menu support for axis tick properties #12133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8b3cbdb
feat: add route and menu support for axis tick properties
gururaj1512 89aaf2c
refactor: use isString helper for type checking in on_change handler
gururaj1512 2a4e041
Apply suggestions from code review
kgryte 5581541
Apply suggestions from code review
kgryte e5c9eb2
Apply suggestions from code review
kgryte 1c8ad74
Apply suggestions from code review
kgryte 324733a
Apply suggestions from code review
kgryte dc661d4
Apply suggestions from code review
kgryte 04e7434
Apply suggestions from code review
kgryte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
lib/node_modules/@stdlib/plot/base/view/lib/browser/routes/app/bundle.js
Large diffs are not rendered by default.
Oops, something went wrong.
43 changes: 43 additions & 0 deletions
43
lib/node_modules/@stdlib/plot/base/view/lib/browser/routes/config/axes/tick-band/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| /** | ||
| * @license Apache-2.0 | ||
| * | ||
| * Copyright (c) 2026 The Stdlib Authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| // MODULES // | ||
|
|
||
| var schema = require( './schema.json' ); | ||
| var handler = require( './main.js' ); | ||
|
|
||
|
|
||
| // MAIN // | ||
|
|
||
| /** | ||
| * Defines a route handler for receiving updating a plot configuration. | ||
| * | ||
| * @private | ||
| * @returns {Object} route declaration | ||
| */ | ||
| function route() { | ||
| schema.handler = handler; | ||
| return schema; | ||
| } | ||
|
|
||
|
|
||
| // EXPORTS // | ||
|
|
||
| module.exports = route; |
57 changes: 57 additions & 0 deletions
57
lib/node_modules/@stdlib/plot/base/view/lib/browser/routes/config/axes/tick-band/main.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| /** | ||
| * @license Apache-2.0 | ||
| * | ||
| * Copyright (c) 2026 The Stdlib Authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| // MODULES // | ||
|
|
||
| var middleware = require( './../../../../middleware_sequence.js' ); | ||
| var allowCredentials = require( './../../../../middleware/allow-credentials' ); | ||
| var tryAssign = require( './../../../../middleware/plot-try-assign' ); | ||
| var body = require( './../../../../middleware/body' ); | ||
| var ok = require( './../../../../middleware/ok' ); | ||
| var onError = require( './../../../../middleware/error' ); | ||
|
|
||
|
|
||
| // VARIABLES // | ||
|
|
||
| var steps = [ | ||
| allowCredentials, | ||
| body, | ||
| tryAssign( [ 'config', 'axes', ':axis' ], 'tickBand' ), | ||
| ok | ||
| ]; | ||
|
|
||
|
|
||
| // MAIN // | ||
|
|
||
| /** | ||
| * Request handler for updating a plot configuration. | ||
| * | ||
| * @private | ||
| * @name handler | ||
| * @type {Function} | ||
| * @param {Object} request - request object | ||
| * @param {Object} response - response object | ||
| */ | ||
| var handler = middleware( steps, onError ); | ||
|
|
||
|
|
||
| // EXPORTS // | ||
|
|
||
| module.exports = handler; |
40 changes: 40 additions & 0 deletions
40
lib/node_modules/@stdlib/plot/base/view/lib/browser/routes/config/axes/tick-band/schema.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| { | ||
| "method": "POST", | ||
| "url": "/config/axes/:axis/tickBand", | ||
| "schema": { | ||
| "response": { | ||
| "200": { | ||
| "type": "string" | ||
| }, | ||
| "400": { | ||
| "type": "object", | ||
| "properties": { | ||
| "statusCode": { | ||
| "type": "integer" | ||
| }, | ||
| "error": { | ||
| "type": "string" | ||
| }, | ||
| "message": { | ||
| "type": "string" | ||
| } | ||
| } | ||
| }, | ||
| "413": { | ||
| "type": "object", | ||
| "properties": { | ||
| "statusCode": { | ||
| "type": "integer" | ||
| }, | ||
| "error": { | ||
| "type": "string" | ||
| }, | ||
| "message": { | ||
| "type": "string" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "handler": null | ||
| } |
43 changes: 43 additions & 0 deletions
43
lib/node_modules/@stdlib/plot/base/view/lib/browser/routes/config/axes/tick-cap/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| /** | ||
| * @license Apache-2.0 | ||
| * | ||
| * Copyright (c) 2026 The Stdlib Authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| // MODULES // | ||
|
|
||
| var schema = require( './schema.json' ); | ||
| var handler = require( './main.js' ); | ||
|
|
||
|
|
||
| // MAIN // | ||
|
|
||
| /** | ||
| * Defines a route handler for receiving updating a plot configuration. | ||
| * | ||
| * @private | ||
| * @returns {Object} route declaration | ||
| */ | ||
| function route() { | ||
| schema.handler = handler; | ||
| return schema; | ||
| } | ||
|
|
||
|
|
||
| // EXPORTS // | ||
|
|
||
| module.exports = route; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.