-
-
Notifications
You must be signed in to change notification settings - Fork 1k
chore: fix C lint errors (issue #9267) #9276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix C lint errors (issue #9267) #9276
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, we cannot accept this PR, as is, due to all the formatting changes. Please make sure you are following stdlib conventions.
22bc1a6 to
41bcf33
Compare
|
@kgryte Thank you for the feedback, I've updated the PR to address the formatting concerns
The changes are now minimal and focused solely on replacing the VLA with dynamic allocation. Please review when you have a chance. |
|
Ref: #9282 |
|
Thank you for working on this pull request. However, we cannot accept your contribution as this pull request does not follow project conventions. We place a high value on consistency throughout the stdlib codebase, and this pull request was found to significantly deviate from stdlib conventions. We encourage you to closely examine other packages in stdlib and attempt to emulate the practices and conventions found therein.
In short, the more effort you put in to ensure that your contribution looks and feels like stdlib—including variables names, bracket spacing, line breaks, etc—the more likely that your contribution will be reviewed and ultimately accepted. We encourage you to closely study the codebase before continuing to work on this pull request. Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions. |
Resolves #9267
Description
This pull request:
description: Fixed C benchmark function to remove variable length array (VLA) and use dynamic allocation with malloc/free.
report:
task: lint_filenames status: na
task: lint_editorconfig status: na
task: lint_markdown status: na
task: lint_package_json status: na
task: lint_repl_help status: na
task: lint_javascript_src status: na
task: lint_javascript_cli status: na
task: lint_javascript_examples status: na
task: lint_javascript_tests status: na
task: lint_javascript_benchmarks status: na
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: passed
task: lint_c_examples status: na
task: lint_c_benchmarks status: na
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: na
task: lint_typescript_tests status: na
task: lint_license_headers status: passed
Resolves None.
Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
@stdlib-js/reviewers