Complete Brazilian Portuguese (pt-BR) localization#1188
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed May 28, 2026, 3:55 PM ET / 19:55 UTC. Summary Reproducibility: yes. from source inspection: current main has 1024 English keys and only 883 pt-BR keys, leaving 141 pt-BR fallbacks to English. I did not run the macOS UI because the remaining proof gate is contributor-visible behavior evidence. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the narrow localization resource update after contributor proof and language review, with maintainers owning the release-note wording if it is intended for the next release. Do we have a high-confidence way to reproduce the issue? Yes from source inspection: current main has 1024 English keys and only 883 pt-BR keys, leaving 141 pt-BR fallbacks to English. I did not run the macOS UI because the remaining proof gate is contributor-visible behavior evidence. Is this the best way to solve the issue? Yes, updating the pt-BR resource file is the narrow maintainable fix for the missing-key fallback. The merge should wait for real UI proof and human language review rather than an automated repair branch. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against ca63a8e7bc1a. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
pt-BR was missing 178 of en.lproj's 785 keys, so those strings fell back to English (a mixed-language UI for Brazilian users). Translate all missing keys to reach full parity with the English base, keeping the same key order as en.lproj. Validated with `plutil -lint`; pt-BR and en key sets and format specifiers (%@, %1$@, %d%%) match exactly (785 keys each, no missing or extra keys).
e199ec5 to
2dec771
Compare
Summary
Localizable.stringswas missing 178 of the 785 keys inen.lproj, so those strings fell back to English (a mixed Portuguese/English UI for Brazilian users).en.lproj.Only
Sources/CodexBar/Resources/pt-BR.lproj/Localizable.stringschanges (+178 keys); no code changes.Validation
plutil -lint Sources/CodexBar/Resources/{en,pt-BR}.lproj/Localizable.strings— both OKenandpt-BRkey sets match exactly (785 keys each, no missing/extra)%@,%1$@,%d%%, …)Notes
main; happy to rebase or trim overlap once Localize popup and provider settings UI #1181 lands."30d cash"→ "Dinheiro de 30d", andquota_warning_notification_titlewas rephrased to read naturally in Portuguese for both the "session" and "weekly" window labels.