Add Poe current balance provider#1191
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed May 28, 2026, 3:44 AM ET / 07:44 UTC. Summary Reproducibility: not applicable. as a feature PR rather than a bug report. The patch is source-reviewable, but the real Poe API behavior is not proven because the PR body only lists lint/build/unit tests. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the narrow balance-only Poe provider after redacted live proof is added and maintainers approve the new API-key provider scope. Do we have a high-confidence way to reproduce the issue? Not applicable as a feature PR rather than a bug report. The patch is source-reviewable, but the real Poe API behavior is not proven because the PR body only lists lint/build/unit tests. Is this the best way to solve the issue? Unclear until proof and sign-off land: the descriptor/fetcher shape is narrow and matches the documented current-balance endpoint, but the best merge path still requires live evidence and maintainer approval of the provider/auth scope. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against dcd43163e0f7. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 917dad2d24
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| supportsTokenCost: false, | ||
| noDataMessage: { "Poe point balance history is not available via API." }), | ||
| fetchPlan: ProviderFetchPlan( | ||
| sourceModes: [.auto, .api], |
There was a problem hiding this comment.
Map Poe apiKey into the fetch environment
When a user configures Poe with source: api and an apiKey in the app config/settings, this advertises that the provider supports API-key config, so CodexBarConfigValidation accepts it. However ProviderConfigEnvironment.directAPIKeyEnvironmentKey(for:) has no .poe case, and UsageStore/ProviderRegistry only pass saved keys to fetchers through applyProviderConfigOverrides; as a result PoeAPIFetchStrategy still sees missing credentials unless POE_API_KEY is present in the process environment. Add a .poe mapping to PoeSettingsReader.apiKeyEnvironmentKey (and expose the settings field if desired) so saved Poe keys actually work.
Useful? React with 👍 / 👎.
917dad2 to
350e8bd
Compare
63b8400 to
fb0bfb5
Compare
fb0bfb5 to
57d257c
Compare
|
Hi, I opened the original issue (#1182). I'm a Poe Plus subscriber, so I'd be happy to |
Summary
Adds minimal Poe provider support in response to #1182, using Poe's official Usage API.
Closes #1182.
Validation