Add first-run onboarding#1194
Conversation
|
Codex review: needs maintainer review before merge. Reviewed May 28, 2026, 9:53 AM ET / 13:53 UTC. Summary Reproducibility: not applicable. this is a feature PR, not a bug report. The contributor supplied after-change video proof showing the onboarding flow in a real app session. Review metrics: 3 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the onboarding after maintainer approval of the first-run provider/default policy and a refreshed current-main check, preserving existing users' settings while keeping the new-user setup flow explicit. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a feature PR, not a bug report. The contributor supplied after-change video proof showing the onboarding flow in a real app session. Is this the best way to solve the issue? Unclear until maintainer product review: the implementation reuses SettingsStore/provider detection and focused tests, but the first-run defaults and automatic completion policy are maintainer decisions rather than pure correctness questions. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against c3bc1adcfafc. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
e17c9ce to
2997303
Compare
2997303 to
eddfaba
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
Summary
Demo
https://karma-dory-nytv.here.now/codexbar-onboarding-demo.mp4
Screenshots
Notes
CodexBar.app; the standalone CLI remains headless.Finish Setup, CodexBar starts background work and opens the menu bar popover automatically.Validation
swift buildswift testswift test --filter 'CodexBarTests.SettingsStoreTests'make checkgit diff --checkcodex review --base origin/mainCodex review found a P3 preview issue where the Appearance preview kept Codex active even when only another provider was selected; fixed by driving the preview from selected providers and falling back to Codex only when the selection is empty.