-
Notifications
You must be signed in to change notification settings - Fork 564
Add configurable quota warning notifications #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DaddioTime
wants to merge
3
commits into
steipete:main
Choose a base branch
from
DaddioTime:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+323
−0
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| import CodexBarCore | ||
| import Foundation | ||
|
|
||
| enum QuotaWarningWindow: String, Sendable { | ||
| case primary | ||
| case secondary | ||
| } | ||
|
|
||
| struct QuotaWarningEvent: Equatable, Sendable { | ||
| let threshold: Int | ||
| let window: QuotaWarningWindow | ||
| let currentRemaining: Double | ||
| } | ||
|
|
||
| enum QuotaWarningNotificationLogic { | ||
| /// Returns thresholds that were newly crossed downward. | ||
| /// A threshold is considered crossed when `previousRemaining > threshold` and | ||
| /// `currentRemaining <= threshold`, and the threshold has not already fired. | ||
| static func crossedThresholds( | ||
| previousRemaining: Double?, | ||
| currentRemaining: Double, | ||
| thresholds: [Int], | ||
| alreadyFired: Set<Int> | ||
| ) -> [Int] { | ||
| guard let previousRemaining else { return [] } | ||
|
|
||
| var crossed: [Int] = [] | ||
| for threshold in thresholds { | ||
| let t = Double(threshold) | ||
| if previousRemaining > t, | ||
| currentRemaining <= t, | ||
| !alreadyFired.contains(threshold) | ||
| { | ||
| crossed.append(threshold) | ||
| } | ||
| } | ||
| return crossed | ||
| } | ||
|
|
||
| /// Returns thresholds that should be cleared from `alreadyFired` because | ||
| /// the remaining percentage has risen back above them. | ||
| static func restoredThresholds( | ||
| currentRemaining: Double, | ||
| alreadyFired: Set<Int> | ||
| ) -> Set<Int> { | ||
| Set(alreadyFired.filter { Double($0) < currentRemaining }) | ||
| } | ||
| } | ||
|
|
||
| @MainActor | ||
| final class QuotaWarningNotifier { | ||
| private let logger = CodexBarLog.logger(LogCategories.quotaWarningNotifications) | ||
|
|
||
| init() {} | ||
|
|
||
| func post(event: QuotaWarningEvent, provider: UsageProvider) { | ||
| let providerName = ProviderDescriptorRegistry.descriptor(for: provider).metadata.displayName | ||
| let windowLabel = event.window == .primary ? "session" : "weekly" | ||
|
|
||
| let title = "\(providerName) \(windowLabel) quota low" | ||
| let body = "\(event.threshold)% remaining – currently at \(Int(event.currentRemaining))%." | ||
|
|
||
| let idPrefix = "quota-warning-\(provider.rawValue)-\(event.window.rawValue)-\(event.threshold)" | ||
| self.logger.info("enqueuing", metadata: ["prefix": idPrefix]) | ||
| AppNotifications.shared.post(idPrefix: idPrefix, title: title, body: body) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This path applies quota-warning transitions to whichever token account is currently selected, but the warning baselines/fired-threshold state in
UsageStoreare keyed only by provider/window. If a user switches from one account to another with a very different remaining quota, the first refresh can look like a large downward crossing and emit false warning notifications even though no quota was consumed on the newly selected account.Useful? React with 👍 / 👎.