Add retries to the install action for resilience#2608
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the repository’s composite GitHub Action (action.yml) that installs stellar-cli, improving CI resilience by retrying network-dependent steps (binary download and attestation verification) instead of failing on transient errors.
Changes:
- Switch the binary download from
curl | tartocurl(with retries/timeouts) downloading into a temp file, then extracting viatar. - Wrap
gh attestation verifyin a 5-attempt retry loop with exponential backoff.
fnando
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make the
stellar/stellar-cliinstall action resilient to transient network failures during the binary download.The
curlcall that fetches the release tarball now retries up to 5 times with backoff (--retry 5 --retry-delay 5 --retry-connrefused --retry-all-errors), bounded by--connect-timeout 30and--max-time 300. The download now writes to a fixed file in$RUNNER_TEMPand is extracted bytarafterwards, rather than pipingcurlstraight intotar, so that a retried transfer can safely restart without corrupting the tar stream. Using a fixed local filename also keeps the download path independent of the (untrusted) version string.Why
A single transient network blip previously failed the whole job — for example this rs-soroban-sdk run failed during the install step. With retries in place, a momentary failure is retried instead of failing the build.
This mirrors the approach taken in stellar/actions#104, which added curl's built-in retry flags to harden a similar download path.
Notes
The
gh attestation verifystep is intentionally left unchanged: theghCLI already retries attestation fetches internally (up to 3 times on 5xx responses), so a separate retry loop there added little.