Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds comprehensive documentation for the Embedded Wallets feature in the Stellar Disbursement Platform (SDP). Embedded Wallets enable receivers to receive disbursements using passkey-secured smart contract wallets without needing to download a separate wallet application.
Changes:
- Added new embedded-wallets.mdx documentation explaining the feature, its benefits, and step-by-step usage guide
- Added Embedded Wallets configuration section to advanced-configuration.mdx with backend, TSS, and frontend setup instructions
- Added screenshot image (SDP48.png) showing the verification prompt interface
- Fixed list formatting in the Distribution Account configuration section
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| embedded-wallets.mdx | New comprehensive guide covering embedded wallets introduction, passkey technology, workflow, prerequisites, and usage steps |
| advanced-configration.mdx | Added embedded wallets configuration section with environment variables for backend, TSS, and frontend; fixed list formatting |
| SDP48.png | New screenshot image showing the verification interface for embedded wallets |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
docs/platforms/stellar-disbursement-platform/admin-guide/embedded-wallets.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/stellar-disbursement-platform/admin-guide/advanced-configration.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/stellar-disbursement-platform/admin-guide/advanced-configration.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/stellar-disbursement-platform/admin-guide/embedded-wallets.mdx
Outdated
Show resolved
Hide resolved
|
Preview is available here: |
1 similar comment
|
Preview is available here: |
docs/platforms/stellar-disbursement-platform/admin-guide/advanced-configuration.mdx
Show resolved
Hide resolved
docs/platforms/stellar-disbursement-platform/admin-guide/embedded-wallets.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/stellar-disbursement-platform/admin-guide/embedded-wallets.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/stellar-disbursement-platform/admin-guide/embedded-wallets.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/stellar-disbursement-platform/admin-guide/embedded-wallets.mdx
Show resolved
Hide resolved
docs/platforms/stellar-disbursement-platform/admin-guide/embedded-wallets.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/stellar-disbursement-platform/admin-guide/embedded-wallets.mdx
Show resolved
Hide resolved
docs/platforms/stellar-disbursement-platform/admin-guide/embedded-wallets.mdx
Outdated
Show resolved
Hide resolved
|
Warning This change removes routes. The diff of routes is below. Please verify that these changes to the routes are intentional and that redirects are in place if needed. Redirects can be added to diff --git a/routes.txt b/routes.txt
index 1dff5f36..5046d891 100644
--- a/routes.txt
+++ b/routes.txt
@@ -600,7 +600,7 @@
/docs/platforms/anchor-platform/sep-guide/sep6/integration
/docs/platforms/stellar-disbursement-platform
/docs/platforms/stellar-disbursement-platform/admin-guide
-/docs/platforms/stellar-disbursement-platform/admin-guide/advanced-configration
+/docs/platforms/stellar-disbursement-platform/admin-guide/advanced-configuration
/docs/platforms/stellar-disbursement-platform/admin-guide/cli-manual
/docs/platforms/stellar-disbursement-platform/admin-guide/configuring-sdp
/docs/platforms/stellar-disbursement-platform/admin-guide/deploy-the-sdp
|
|
Preview is available here: |
marwen-abid
force-pushed
the
sdp/SDP-1637-embedded-wallets-docs
branch
from
d3c5c1a to
9bc07f3
Compare
|
Warning This change removes routes. The diff of routes is below. Please verify that these changes to the routes are intentional and that redirects are in place if needed. Redirects can be added to diff --git a/routes.txt b/routes.txt
index 1dff5f36..5d178438 100644
--- a/routes.txt
+++ b/routes.txt
@@ -600,11 +600,12 @@
/docs/platforms/anchor-platform/sep-guide/sep6/integration
/docs/platforms/stellar-disbursement-platform
/docs/platforms/stellar-disbursement-platform/admin-guide
-/docs/platforms/stellar-disbursement-platform/admin-guide/advanced-configration
+/docs/platforms/stellar-disbursement-platform/admin-guide/advanced-configuration
/docs/platforms/stellar-disbursement-platform/admin-guide/cli-manual
/docs/platforms/stellar-disbursement-platform/admin-guide/configuring-sdp
/docs/platforms/stellar-disbursement-platform/admin-guide/deploy-the-sdp
/docs/platforms/stellar-disbursement-platform/admin-guide/design-and-architecture
+/docs/platforms/stellar-disbursement-platform/admin-guide/embedded-wallets
/docs/platforms/stellar-disbursement-platform/admin-guide/getting-started
/docs/platforms/stellar-disbursement-platform/admin-guide/making-your-wallet-sdp-ready
/docs/platforms/stellar-disbursement-platform/admin-guide/monitoring
|
|
Preview is available here: |
marwen-abid
force-pushed
the
sdp/SDP-1637-embedded-wallets-docs
branch
from
9bc07f3 to
f183a82
Compare
|
Warning This change removes routes. The diff of routes is below. Please verify that these changes to the routes are intentional and that redirects are in place if needed. Redirects can be added to diff --git a/routes.txt b/routes.txt
index 1dff5f36..5d178438 100644
--- a/routes.txt
+++ b/routes.txt
@@ -600,11 +600,12 @@
/docs/platforms/anchor-platform/sep-guide/sep6/integration
/docs/platforms/stellar-disbursement-platform
/docs/platforms/stellar-disbursement-platform/admin-guide
-/docs/platforms/stellar-disbursement-platform/admin-guide/advanced-configration
+/docs/platforms/stellar-disbursement-platform/admin-guide/advanced-configuration
/docs/platforms/stellar-disbursement-platform/admin-guide/cli-manual
/docs/platforms/stellar-disbursement-platform/admin-guide/configuring-sdp
/docs/platforms/stellar-disbursement-platform/admin-guide/deploy-the-sdp
/docs/platforms/stellar-disbursement-platform/admin-guide/design-and-architecture
+/docs/platforms/stellar-disbursement-platform/admin-guide/embedded-wallets
/docs/platforms/stellar-disbursement-platform/admin-guide/getting-started
/docs/platforms/stellar-disbursement-platform/admin-guide/making-your-wallet-sdp-ready
/docs/platforms/stellar-disbursement-platform/admin-guide/monitoring
|
|
Preview is available here: |
marwen-abid
force-pushed
the
sdp/SDP-1637-embedded-wallets-docs
branch
from
f183a82 to
a79b3fb
Compare
|
Warning This change removes routes. The diff of routes is below. Please verify that these changes to the routes are intentional and that redirects are in place if needed. Redirects can be added to diff --git a/routes.txt b/routes.txt
index 36f2a094..a938acb2 100644
--- a/routes.txt
+++ b/routes.txt
@@ -600,11 +600,12 @@
/docs/platforms/anchor-platform/sep-guide/sep6/integration
/docs/platforms/stellar-disbursement-platform
/docs/platforms/stellar-disbursement-platform/admin-guide
-/docs/platforms/stellar-disbursement-platform/admin-guide/advanced-configration
+/docs/platforms/stellar-disbursement-platform/admin-guide/advanced-configuration
/docs/platforms/stellar-disbursement-platform/admin-guide/cli-manual
/docs/platforms/stellar-disbursement-platform/admin-guide/configuring-sdp
/docs/platforms/stellar-disbursement-platform/admin-guide/deploy-the-sdp
/docs/platforms/stellar-disbursement-platform/admin-guide/design-and-architecture
+/docs/platforms/stellar-disbursement-platform/admin-guide/embedded-wallets
/docs/platforms/stellar-disbursement-platform/admin-guide/getting-started
/docs/platforms/stellar-disbursement-platform/admin-guide/making-your-wallet-sdp-ready
/docs/platforms/stellar-disbursement-platform/admin-guide/monitoring
|
|
Preview is available here: |
docs/platforms/stellar-disbursement-platform/admin-guide/advanced-configuration.mdx
Show resolved
Hide resolved
|
|
||
| :::note | ||
|
|
||
| There is also a "No Verification" option, but using it is only recommended for low-risk scenarios due to security concerns (e.g. disbursing small amounts). |
There was a problem hiding this comment.
It's called None in the UI.
|
|
||
| :::danger | ||
|
|
||
| Each link is unique per receiver. Treat it as sensitive: if a link is leaked and you have **no verification** enabled, an attacker could create the receiver’s wallet and claim the funds. Skipping verification should only be done in low-risk scenarios and with small disbursement amounts. |
There was a problem hiding this comment.
We should also recommend having verification because it forces the user through SEP-45, which verifies that the passkey works before sending funds to them. We've seen some cases at Meridian where the accounts were created, funds disbursed, but the users were unable to transfer out due to issues with their passkeys.
4 participants
No description provided.