Adds config flag to retain ids in output queries#14
Open
stjohncj wants to merge 1 commit intosteventen:masterfrom
Open
Adds config flag to retain ids in output queries#14stjohncj wants to merge 1 commit intosteventen:masterfrom
stjohncj wants to merge 1 commit intosteventen:masterfrom
Conversation
Owner
|
Hi @stjohncj thanks for submitting a PR! It looks like you want an option to disable the redaction or sanitization process? In that case, I'd prefer a better name other than retain ids, since it may not always be an ID to be removed. Maybe |
steventen
reviewed
May 9, 2022
| query.gsub!(/(\sVALUES\s)\(.+\)/i, '\1(xxx)') | ||
| query.gsub!(/(\s(LIKE|ILIKE|SIMILAR TO|NOT SIMILAR TO)\s)('[^']+')/i, '\1xxx') | ||
| query.gsub!(/(\s(LIMIT|OFFSET)\s)(\d+)/i, '\1xxx') | ||
| unless @config&.retain_sql_query_ids |
Owner
There was a problem hiding this comment.
I think It's better to return the query directly instead of wrapping everything in the conditional block.
So something like:
Suggested change
| unless @config&.retain_sql_query_ids | |
| return query if @config&.retain_sql_query_ids |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test as well