Skip to content

(Towards #3060) reference accesses for intrinsicCall#3125

Merged
sergisiso merged 57 commits intomasterfrom
3060_reference_accesses
Feb 16, 2026
Merged

(Towards #3060) reference accesses for intrinsicCall#3125
sergisiso merged 57 commits intomasterfrom
3060_reference_accesses

Conversation

@LonelyCat124
Copy link
Copy Markdown
Collaborator

No description provided.

@LonelyCat124 LonelyCat124 changed the title (3060 reference accesses (Closes #3060) reference accesses for intrinsicCall Sep 8, 2025
@LonelyCat124
Copy link
Copy Markdown
Collaborator Author

Follow-on to #3119

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (c9a794c) to head (aedfeb6).
⚠️ Report is 58 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3125      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         382      382              
  Lines       54107    54049      -58     
==========================================
- Hits        54085    54027      -58     
  Misses         22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LonelyCat124 LonelyCat124 added ready for review Blocked An issue/PR that is blocked by one or more issues/PRs. and removed in progress labels Sep 11, 2025
@LonelyCat124
Copy link
Copy Markdown
Collaborator Author

@sergisiso I have a first implementation of this now if you want to examine it if you have time. Its currently "blocked" by #3119 (which is in turn dependent on #3110 ) so there's very much no rush on this, especially if I do solve some other issues before we merge 3319.

@LonelyCat124
Copy link
Copy Markdown
Collaborator Author

@sergisiso Ready for a review when you're back from leave.

Copy link
Copy Markdown
Collaborator

@sergisiso sergisiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there now @LonelyCat124, just one more possible simplification and small clean ups.

Comment thread src/psyclone/psyir/nodes/intrinsic_call.py Outdated
Comment thread src/psyclone/psyir/nodes/intrinsic_call.py
Comment thread src/psyclone/psyir/nodes/intrinsic_call.py Outdated
Comment thread src/psyclone/psyir/nodes/intrinsic_call.py Outdated
Comment thread src/psyclone/psyir/nodes/intrinsic_call.py
Comment thread src/psyclone/psyir/nodes/intrinsic_call.py Outdated
@LonelyCat124
Copy link
Copy Markdown
Collaborator Author

@sergisiso Ready for another look, I did swap to the default as you suggested.

Copy link
Copy Markdown
Collaborator

@sergisiso sergisiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good now @LonelyCat124, it ITs come green I will proceed to merge.

@sergisiso sergisiso merged commit dbbb301 into master Feb 16, 2026
15 checks passed
@sergisiso sergisiso deleted the 3060_reference_accesses branch February 16, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants