Skip to content

(Towards #2381 #2674) generalise GH_SUM Kernel metadata to GH_REDUCTION and begin support for new min/max LFRic builtins#3263

Merged
sergisiso merged 72 commits intomasterfrom
2381_min_max_builtins
Jan 22, 2026
Merged

(Towards #2381 #2674) generalise GH_SUM Kernel metadata to GH_REDUCTION and begin support for new min/max LFRic builtins#3263
sergisiso merged 72 commits intomasterfrom
2381_min_max_builtins

Conversation

@arporter
Copy link
Copy Markdown
Member

@arporter arporter commented Dec 18, 2025 •
edited
Loading

This is a step towards both #2381 (generalising global reductions) and #2674 (new field_min_max builtin). It attempts to reduce the size of #3222 by only adding the two new access types for reductions as well as the skeletons for the new builtins.

arporter and others added 30 commits October 3, 2025 21:56
@arporter
#2381 add initial GlobalReduction class
c871676
@arporter
#2381 linting
b0c458c
@arporter
#2381 mv LFRicGlobalSum out of lfric.py and rename
0d5dadf
@arporter
#2381 fix linting
6856abd
@arporter
#2381 ensure any pre-existing Config is wiped by test fixture
279ec53
@arporter
#2381 WIP fixing/moving tests [skip ci]
4a2f3d4
@arporter
#2381 fix all tests
9eb6784
@arporter
#2381 tidy and improve tests
5921958
@arporter
Merge branch 'master' into 2381_arp_global_reduction
de51056
@arporter
#2381 get full unit coverage for global_reduction
49b856b
@arporter
Merge branch 'master' into 2381_arp_global_reduction
6aa870c
@arporter
#2381 update from global sum to global reduction
355a900
@arporter
#2381 fix linting
88956f8
@arporter
#2381 tidy test file
488d0a5
@arporter
Merge branch 'master' into 2381_arp_global_reduction
c27c9ab
@arporter
Merge branch '2381_arp_global_reduction' of github.com:stfc/PSyclone …
7fe581b 
…into 2381_arp_global_reduction
@arporter
Merge branch 'master' into 2381_arp_global_reduction
5b4d364
@arporter
Merge branch '2381_arp_global_reduction' of github.com:stfc/PSyclone …
faa440b 
…into 2381_arp_global_reduction
@arporter
#2381 update docs
d26c56c
@arporter
Merge branch 'master' into 2381_arp_global_reduction
ae2fb6d
@arporter
Merge branch 'master' into 2381_arp_global_reduction
c6d6366
@arporter
#2381 rejig class hierarchy
226cfeb
@arporter
#2381 start adding an LFRicGlobalMin to test new structure
134954d
@arporter
#2381 tidy for lint
72dd101
@arporter
Merge branch 'master' into 2381_no_domain_global_reduction
cf9c5c3
@arporter
Merge branch 'master' into 2381_no_domain_global_reduction
fead32a
@arporter
#2381 WIP updating lower_to_language_level [skip-ci]
5a0654a
@arporter
Merge branch 'master' into 2381_no_domain_global_reduction
eee9422
@arporter
#2381 flesh out LFRicGlobalMin
9fc397b
@arporter
#2381 make dag_name more general
0523346
@arporter
Copy link
Copy Markdown
Member Author

arporter commented Jan 20, 2026

This is ready for another look now @sergisiso.

sergisiso
sergisiso requested changes Jan 21, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@sergisiso sergisiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arporter Can you also update the title, are any of the issues now ready to close?

Comment thread src/psyclone/domain/lfric/lfric_builtins.py
@arporter arporter changed the title (Towards #2381 #2674) add min max access types and new LFRic builtins (Towards #2381 #2674) generalise GH_SUM to GH_REDUCTION and begin support for new min/max LFRic builtins Jan 22, 2026
@arporter
Copy link
Copy Markdown
Member Author

arporter commented Jan 22, 2026

I've updated the title. Unfortunately this won't close any tickets yet (as it doesn't actually touch the global-sum/reduction functionality).

@arporter arporter changed the title (Towards #2381 #2674) generalise GH_SUM to GH_REDUCTION and begin support for new min/max LFRic builtins (Towards #2381 #2674) generalise GH_SUM Kernel metadata to GH_REDUCTION and begin support for new min/max LFRic builtins Jan 22, 2026
@arporter
Copy link
Copy Markdown
Member Author

arporter commented Jan 22, 2026

Ready for another look/further discussion now @sergisiso.

sergisiso
sergisiso approved these changes Jan 22, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@sergisiso sergisiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the changes @arporter , I triggered the IT once more to be cautions but I don't expect any problem since this is still not used in LFRic (as its not finished for DM). I will merge if all comes green.

@sergisiso sergisiso merged commit 152a9c3 into master Jan 22, 2026
15 checks passed
@sergisiso sergisiso deleted the 2381_min_max_builtins branch January 22, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergisiso sergisiso sergisiso approved these changes

Assignees

@arporter arporter

Labels

LFRic PSyKAl-lite Issue related to removal of PSyKAl-lite code in LFRic LFRic Issue relates to the LFRic domain ready to be merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arporter @sergisiso