Skip to content

(Towards #2971) Moved OMPParallelTrans to psyir.transformations#3280

Merged
arporter merged 20 commits intomasterfrom
2971_move_omp_parallel_trans
Jan 23, 2026
Merged

(Towards #2971) Moved OMPParallelTrans to psyir.transformations#3280
arporter merged 20 commits intomasterfrom
2971_move_omp_parallel_trans

Conversation

@LonelyCat124
Copy link
Copy Markdown
Collaborator

@LonelyCat124 LonelyCat124 commented Jan 13, 2026

No description provided.

@LonelyCat124 LonelyCat124 mentioned this pull request Jan 13, 2026
Merged
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 13, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (08a2e70) to head (08fbd17).
⚠️ Report is 21 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3280   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         378      379    +1     
  Lines       53803    53811    +8     
=======================================
+ Hits        53781    53789    +8     
  Misses         22       22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LonelyCat124
Copy link
Copy Markdown
Collaborator Author

LonelyCat124 commented Jan 13, 2026

@sergisiso @arporter Mostly a small PR ready for a look, just moves the transformation and fixes the scripts I found. I'm going to set integration tests running now as well in case I missed anything.

@LonelyCat124
Copy link
Copy Markdown
Collaborator Author

LonelyCat124 commented Jan 13, 2026

integration passes so ready for review.

arporter
arporter requested changes Jan 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Aidan.
Mostly good but I'm worried that we're no longer testing the 'transmutation' part of LFRic-atm - see inline. (I may be mistaken though.)

Comment thread .github/workflows/lfric_test.yml Outdated
Comment thread src/psyclone/psyir/transformations/omp_parallel_trans.py Outdated
@LonelyCat124
Copy link
Copy Markdown
Collaborator Author

LonelyCat124 commented Jan 15, 2026

lfric core: 4eec06e08e19ac23a894fcfdad691132ffc68293
lfric atm: b0c43b04041d929ffc887f82f27263d9a0feaa2d

@LonelyCat124 LonelyCat124 added the Blocked An issue/PR that is blocked by one or more issues/PRs. label Jan 16, 2026
@LonelyCat124
Copy link
Copy Markdown
Collaborator Author

LonelyCat124 commented Jan 16, 2026

Blocked by #3286

@LonelyCat124 LonelyCat124 removed the Blocked An issue/PR that is blocked by one or more issues/PRs. label Jan 19, 2026
@LonelyCat124 LonelyCat124 requested a review from arporter January 21, 2026 10:59
@LonelyCat124
Copy link
Copy Markdown
Collaborator Author

LonelyCat124 commented Jan 21, 2026

@arporter I think this is ready for another look with the CI failing just being the broken link we discussed on teams.

arporter
arporter previously approved these changes Jan 22, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good now, thanks Aidan.
I'll re-run the ITs just to be sure.

@arporter arporter dismissed their stale review January 22, 2026 11:45

This PR needs to wait for #3216 and then will need the lfric_core/apps branches updating.

@LonelyCat124
Copy link
Copy Markdown
Collaborator Author

LonelyCat124 commented Jan 22, 2026

ITs failed, but it was an error 500 on the lfric_core repo so I'm rerunning it as that seems more likely to be a gh failure than the ITs.

@arporter
Copy link
Copy Markdown
Member

arporter commented Jan 23, 2026

Thanks for launching the ITs Aidan. Everything was green so this is good to merge.

arporter
arporter approved these changes Jan 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now.

@arporter arporter merged commit 60c3bf6 into master Jan 23, 2026
15 checks passed
@arporter arporter deleted the 2971_move_omp_parallel_trans branch January 23, 2026 09:18
arporter added a commit to stfc/lfric_core that referenced this pull request Jan 23, 2026
@arporter
Merge pull request #1 from stfc/2971_move_omp_parallel_trans
b486758 
(For stfc/PSyclone#3280) Update OMPParallelTrans import location
arporter added a commit to stfc/lfric_apps that referenced this pull request Jan 26, 2026
@arporter
Merge pull request #1 from stfc/2971_move_omp_parallel_trans
bc22490 
(For stfc/PSyclone#3280)  Update OMPParallelTrans import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arporter arporter arporter approved these changes

@sergisiso sergisiso Awaiting requested review from sergisiso

Assignees

No one assigned

Labels

ready to be merged under review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LonelyCat124 @arporter @sergisiso